Thread:Rappy 4187/@comment-917693-20181030214804

Hey,

I'd appreciate a short explanation as to why you made the changes you did in the Wikia.js.


 * https://utaite.fandom.com/wiki/MediaWiki:Wikia.js?diff=174290&oldid=174274
 * Here your commit message doesn't seem to match your edit. Was there a reason you removed the code there? That was functional code used for the template preloads. Note: You included standard summaries in ImprotJS, but the code was in fact for something else: for custom template insertions.
 * https://utaite.fandom.com/wiki/MediaWiki:Wikia.js?diff=prev&oldid=174292
 * Why did you introduce "preloadTemplates_list"? It isn't used anywhere in the code. I suppose because of the standard summaries, but then again that's not what we wanted to achieve...
 * https://utaite.fandom.com/wiki/MediaWiki:Wikia.js?diff=next&oldid=174292
 * Did you change anything else aside from the reformatting? I see at the very bottom you removed "customPreloadTemplates;". Are there any more removals, and why? Was the removal of "customPreloadTemplates;" accidental?
 * https://utaite.fandom.com/wiki/MediaWiki:Wikia.js?diff=next&oldid=174293
 * The script you removed was in fact not unused, before your edits. It was used by the code you deleted in your first edit. Also can you give me a short explanation as to in which way the tips functions were vulnerable to XSS? It all seems fine to me. 